[PLAT-6614] Stop session being reported if app is launched in the background #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
approved these changes
Jun 3, 2021
|
Does this mean if the app crashes during a background fetch, we'll no longer get crash reports? I'm not sure that's desirable. It's still useful to know about app crashes, since iOS can stop calling you for background fetches if the app is misbehaving |
|
@sethfri this does not stop crashes being reported, but it does mean they will no longer count against the app's stability score. |
|
@nickdowell Thanks for clarifying! |
This was referenced Sep 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
A session should not be reported if an app was started in the background (for example to perform a background fetch.)
Only once a user opens the app (and it moves to the foreground) should a session be recorded.
Changeset
BugsnagClientnow checks whether the app is in the foreground before starting a session.BugsnagSessionTrackernow starts a session as soon as the app moves into the foreground if there was no previous session.Testing
Manual testing only because it's not possible to trigger a background launch via Appium.
In one of the example Xcode projects, add the background fetch capability and then in the scheme's run options enable the Background Fetch option. Note: this only works when debugging an app.
E2E tests verify that automatic sessions reporting still works when an app is launched in the foreground.