[PLAT-6632] Fix KSCrash state storage for apps with no CFBundleName

[nickdowell]

Goal

Some apps (e.g. macOS command line tools and background daemons) may not have an Info.plist or CFBundleName, and this was causing the KSCrash state persistence to fail, resulting in failing to detect that the last run ended with a crash.

Changeset

When constructing the stateFilePath, the notifier now falls back to the process's name if it the app has no bundle name.

The bundle name is also no longer included in the KSCrashReport file names.

Testing

Reproduced the reported issue using the macOS stress test app and verified the fix.

E2E tests ensure that crash reporting continues to work as expected.

[github-actions]

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size decreased by 448 bytes from 1,126,712 to 1,126,264 🎉

Generated by 🚫 Danger

[kattrali]

What does this change mean for people who upgrade and have existing data in the "{bundle name}" directory?

[kstenerud]

Will this handle migration from the old filenames to the new ones?

[nickdowell]

The KSCrash state file path remains KSCrashReports/${bundleName}-CrashState.json for apps with a bundle name.

Apps without a bundle name were never able to save a state file due to the invalid generated path, so there's nothing to migrate. They will now use KSCrashReports/${processName}-CrashState.json

The other change contained here is to strip the bundle name from the name of each KSCrashReport file. This does not require migration because BSGEventUploader will pick up any json file that does not end with -CrashState.json.