[PLAT-6482] Internal error reporting #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User info is ignored by the event server for internal errors
kstenerud
requested changes
May 10, 2021
kstenerud
approved these changes
May 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Enables errors within the notifier to be reported to Bugsnag for further investigation.
Implements sending an internal error if crash reports fail to parse correctly.
Design
See engineering design document.
Changeset
BSGInternalErrorReporterimplements the formatting and sending of internal error event.BSGEventUploadKSCrashReportOperationhas been updated to send error events for various different parsing errors.Testing
Tested manually using a sample app and creating an invalid JSON file in the KSCrashReports directory. Reported errors look like this in the dashboard:
Unit tests have been added to verify the BugsnagEvent and NSURLRequest objects are populated as expected.
Added E2E scenario to verify that an internal error is reported if an invalid KSCrashReport is encountered (results).