-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAT-6370 unity support #1088
PLAT-6370 unity support #1088
Conversation
This has introduced a lint warning, and I'm not sure that the introduction of an "unknown" string is desirable. Maybe the Unity layer could deal with the NSDictionary representation which can be accessed via |
I'd rather avoid using dictionary lookups to get internal values and instead make use of the type checker and type bindings. Otherwise we have to manually keep everything in sync across multiple projects, and that's asking for trouble. |
1633249
to
9054f7a
Compare
#ifdef __cplusplus | ||
extern "C" { | ||
#endif | ||
|
||
NSString *BSGBreadcrumbTypeValue(BSGBreadcrumbType type); | ||
BSGBreadcrumbType BSGBreadcrumbTypeFromString( NSString * _Nullable value); | ||
|
||
#ifdef __cplusplus | ||
} | ||
#endif | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the FOUNDATION_EXPORT
macro to take care of the extern "C"
dance thereby tidying up the code a bit:
#ifdef __cplusplus | |
extern "C" { | |
#endif | |
NSString *BSGBreadcrumbTypeValue(BSGBreadcrumbType type); | |
BSGBreadcrumbType BSGBreadcrumbTypeFromString( NSString * _Nullable value); | |
#ifdef __cplusplus | |
} | |
#endif | |
FOUNDATION_EXPORT NSString *BSGBreadcrumbTypeValue(BSGBreadcrumbType type); | |
FOUNDATION_EXPORT BSGBreadcrumbType BSGBreadcrumbTypeFromString(NSString * _Nullable value); |
…snagBreadcrumb+Private.h
9054f7a
to
1bee854
Compare
Goal
Expose
BSGBreadcrumbTypeValue
andBSGBreadcrumbTypeFromString
via BugsnagBreadcrumb+Private.hThis is needed to support bugsnag/bugsnag-unity#234
Testing
Re-run unit and e2e tests