Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6291] Ignore app hangs when a debugger is attached #1058

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Mar 31, 2021

Goal

App hangs were being reported if a breakpoint was hit on an app's main thread.

Changeset

The app hang detector now checks if a debugger is attached, and avoids reporting if so.

Testing

Tested manually using example app.

@nickdowell nickdowell marked this pull request as ready for review March 31, 2021 13:57
@github-actions
Copy link

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size did not change - 1,102,512 bytes

Generated by 🚫 Danger

@nickdowell nickdowell merged commit da15344 into next Apr 1, 2021
@nickdowell nickdowell deleted the nickdowell/app-hangs-ptrace branch April 1, 2021 07:12
@nickdowell nickdowell mentioned this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants