-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I can't install Bugsnag on Carthage + Xcode11 #418
Comments
+1 Same issue here, I'm looking into a fix. The xcodebuild log ends with:
|
For the time being, I've just reverted the commit that broke Carthage. No PR because this is not a real "fix" - https://github.com/Sidetalker/bugsnag-cocoa |
Hi @marcelosalloum @Sidetalker Thanks, we'll take a look at what's required for the proper fix for this. |
I'm seeing a similar/same error. What is weird is that Here's the error output:
|
Yep @EmDee, that’s consistent with what I’m seeing. From what I can tell the project started using a common xcconfig that covered all the platforms so Carthage can no longer tell what’s an iOS workspace. |
By the way: I can install |
Thanks a lot, @EmDee! That works for me too.
Your branch hasn't worked for me, @Sidetalker. I'm on Xcode 11 + MacOS 10.15 Beta 10 |
This is very weird; all of the Xcode projects were updated to be multi-platform, with the intent to:
If I open OSX.xcworkspace, the framework target can be added to any platform, so I'm trying to figure out why Carthage is building for macOS. |
Now that I say that, I think I figured it out. This is working for me, can someone verify that my fix works for them by adding this to their cartfile:
|
@kattrali, this fix has entered a build loop for me: |
@marcelosalloum you should specify the "master" branch as I haven't bothered to update the release tag. Your Cartfile entry should be |
Try removing |
@kattrali I've made some updates to your changes so we no longer build all three frameworks when My changes update scheme names to make it obvious what is building and set the SUPPORTED_PLATFORMS for each of the projects so that Carthage knows which ones to build. |
Ok @kattrali, cleaning the cache and updating carthage did the trick, which means this update command is working for me: |
Fixes an issue mentioned in #418 where the Bugsnag project would build multiple times, once for each architecture.
Fixes an issue mentioned in #418 where the Bugsnag project would build multiple times, once for each architecture.
Thanks for checking, @marcelosalloum.
Thanks for this, @Sidetalker. The changeset resolves the issue, but due to the way that some people integrate (vendoring/submoduling I am working on a slightly different approach in the branch kattrali/fix-carthage-building-multiple-times which instead removes the different projects in favor of one in the root of the repository, which resolves the build repeat issue as well as reducing risk of Carthage builds for the different platforms being different from counterparts using other packaging systems. |
Great, thanks for the update @kattrali! |
Released in v5.22.9 |
Description
Bugsnag won't install using XCode 11 + Carthage
Environment
Library versions:
5.22.7
0.33
MacOSX 10.15 Catalina
Example code snippet
carthage update bugsnag-cocoa --no-use-binaries --cache-builds --platform iOS
Result
The text was updated successfully, but these errors were encountered: