[PLAT-31288] Split out ending a span and closing/sending for processing #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The RN library needs to be able to set the end time multiple times, so we need to split out:
Design
BugsnagPerformanceSpan
now has two new internal APIs:- (void)markEndTime:(NSDate *)endTime
to set the end time of the span (can be called multiple times)- (void)sendForProcessing
to send for processing (idempotent, only performs operation once)Testing
Existing tests are sufficient since the public
end
functions now call these functions.