Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-11205] Add view load phase API that can be called from Swift #220

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

kstenerud
Copy link
Contributor

Goal

Adds a swift-accessible API for view load phase spans, which will be used in the upcoming SwiftUI instrumentation API.

Testing

Added e2e test

Copy link

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.3%    +424  +0.3%    +424    String Table
  +0.4%    +364  +0.4%    +364    __TEXT,__text
  +0.3%    +224  +0.3%    +224    Symbol Table
  +0.5%     +52  +0.5%     +52    __TEXT,__objc_methname
  +0.5%     +48  +0.5%     +48    __TEXT,__gcc_except_tab
  +0.2%     +24  +0.2%     +24    __DATA,__objc_const
  +0.5%     +20  +0.5%     +20    __TEXT,__unwind_info
  +0.7%     +17  +0.7%     +17    __TEXT,__objc_methtype
  -0.5%     -24  -0.5%     -24    [__DATA]
  -1.5%    -501  -1.5%    -501    [__TEXT]
  [ = ]       0  -7.4%    -648    [__LINKEDIT]
  +0.1%    +648  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud merged commit 1b8acb5 into next Nov 24, 2023
1 check passed
@kstenerud kstenerud deleted the PLAT-11205-view-load-phase-api-2 branch November 24, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants