Add build support #13
Conversation
|
I think this is more or less what we wanted now. I'll update the docs to reflect the changes for rake/heroku users. |
|
Awesome, when will this be released? |
|
Does the usage of this match what you expect/wanted from it @snmaynard ? |
| rescue | ||
| logger.important("Bugnsag deploy notification failed, #{$!.inspect}") | ||
| logger.important("Bugnsag release notification failed, #{$!.inspect}") |
| :api_key => fetch(:bugsnag_api_key, ENV["BUGSNAG_API_KEY"]), | ||
| :app_version => fetch(:app_version, ENV["BUGSNAG_APP_VERSION"]), | ||
| :auto_assign_release => fetch(:bugsnag_auto_assign_release, nil), |
| after "deploy", "bugsnag:deploy" | ||
| after "deploy:migrations", "bugsnag:deploy" | ||
| after "deploy", "bugsnag:release" | ||
| after "deploy:migrations", "bugsnag:release" |
There was a problem hiding this comment.
I dont know why there is deploy:migrations here too.
| :api_key => fetch(:bugsnag_api_key, ENV["BUGSNAG_API_KEY"]), | ||
| :app_version => fetch(:app_version, ENV["BUGSNAG_APP_VERSION"]), | ||
| :auto_assign_release => fetch(:bugsnag_auto_assign_release), |
There was a problem hiding this comment.
Should be env var here
| :api_key => fetch(:bugsnag_api_key, ENV["BUGSNAG_API_KEY"]), | ||
| :app_version => fetch(:app_version, ENV["BUGSNAG_APP_VERSION"]), | ||
| :auto_assign_release => fetch(:bugsnag_auto_assign_release, ENV["BUGSNAG_AUTO_ASSIGN_RELEASE"]), |
There was a problem hiding this comment.
Have you tested the env variable. I dont think it will work.
There was a problem hiding this comment.
Looks about ready. Blocking bits:
require "pp"present in the capistrano2 integration and the exampleCapfiles- The docs suggest using
require: falsewhen adding bugsnag-cap to a Gemfile, but that isn't done in the examples - there's no need for the "with/without Bugsnag" bits in the tests
| @@ -1,26 +1,31 @@ | |||
| require 'pp' | |||
|
Is covering the case where Capistrano can pull configuration details from Bugsnag-Ruby not required? |
|
ah, nvm the last bit about the tests. I thought it hadn't been updated to match since it uses doubles now. |
Here is what I have so far.
I removed the heroku support in favour of documenting the CLI. I have also removed rake support as this should be focused on capistrano imo. This is currently untested but I think directionally ok. Thoughts @Cawllec?