Avoid crash when initializing bugsnag in attachBaseContext #953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoids a crash when initializing Bugsnag in
Application#attachBaseContext()
. Previously Bugsnag always attempted to obtain the application context to avoid leaking short-lived activity context. However, at this point in time the application context will return null, resulting in anIllegalArgumentException
within theClient
constructor.This changeset fixes this by adding a null check. If the context does return null then it is the base context, and its safe to initialize with as it won't leak memory unlike an
Activity
.Testing
Tested manually in an example app as this is not a suitable scenario for mazerunner. Added unit tests to confirm that the original crash does not occur.