Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-4704] RN: Split updateMetadata method into two separate add/clear methods #918

Merged
merged 1 commit into from
Aug 4, 2020
Merged

[PLAT-4704] RN: Split updateMetadata method into two separate add/clear methods #918

merged 1 commit into from
Aug 4, 2020

Conversation

bengourley
Copy link
Contributor

Splits out the add/removal of metadata to facilitate more accurate synchronisation from the JS layer in RN.

@bengourley bengourley mentioned this pull request Aug 4, 2020
Merged
fractalwrench
fractalwrench approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI.

@bengourley bengourley merged commit 09079d0 into master Aug 4, 2020
@bengourley bengourley deleted the bengourley/rn-metadata-refactor branch August 4, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengourley @fractalwrench