Avoid attempting to flush unhandled error reports in same session #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
unhandled-flush
branch
from
65c5ed7
to
e852850
Compare
Android notifier sizes
Generated by 🚫 Danger |
fractalwrench
force-pushed
the
unhandled-flush
branch
3 times, most recently
from
a65addf
to
3740c9c
Compare
bugsnag-android-core/src/main/java/com/bugsnag/android/DeliveryDelegate.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/DeliveryDelegate.java
Outdated
Show resolved
Hide resolved
fractalwrench
force-pushed
the
unhandled-flush
branch
from
3740c9c
to
101bcc1
Compare
tomlongridge
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When an unhandled error is captured the process is usually about to terminate. Currently bugsnag attempts to send the request which can lead to a condition where a request is successfully sent but the process is terminated before the SDK can act on the response. This can lead to duplicate error reports on the relaunch of the app (and is theorised to cause flakes in the E2E tests).
Disabling this behaviour for unhandled errors will reduce the likelihood of these duplicate requests being sent. This excludes the following ANRs, because the process will not directly terminate and there's a good chance the request will be delivered in the same session.
Tests
Added unit tests to cover ANR calculations.