Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check when loading data from manifest #878

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds a null check when loading meta-data from the manifest. In a React Native 0.55 example app with no meta-data elements present in the manifest, applicationInfo.metadata was returned as null by the PackageManager.

It's hypothesised that this was caused by a very old targetSdkVersion/compileSdkVersion, and can be demonstrated to be caused by the lack of any meta-data elements in the manifest, making this a relatively rare scenario. A null check has been added regardless.

@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1434.34 1363.74
arm64_v8a 365.78 293.15
armeabi 344.28 271.64
armeabi_v7a 327.08 254.44
x86 403.77 331.13
x86_64 386.45 313.81

Generated by 🚫 Danger

Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is now working on the project where the issue was identified.

@fractalwrench fractalwrench merged commit b57492c into v5-react-native Apr 30, 2020
@fractalwrench fractalwrench deleted the v5rn-manifest-fix branch April 30, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants