Create observer before registering plugin #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
approved these changes
Apr 23, 2020
I think packaging AARs in the node_modules should be helpful at preventing this kind of thing, as I assume this was tested with a local AAR artefact on the React Native example app but Gradle incorrectly used a stale version of bugsnag-android. This will be addressed in the following PR: bugsnag/bugsnag-js#815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Creates the observer before it is registered, otherwise this triggers an exception as the
lateinit varwill not have been initialised. This crashed the Bugsnag react native pluginTests
Manually verified with a local artefact on the v7-react-native example app