Allow overriding the versionCode via Configuration #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows overriding the versionCode either through a manifest meta-data element or programmatically on the Configuration object. This facilitates grouping for custom versioning schemes. By default, the versionCode still equals the android:versionCode manifest value (once a Client has been instantiated)
tomlongridge
reviewed
Oct 9, 2019
bugsnag-android-core/src/main/java/com/bugsnag/android/AppData.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allows overriding the
versionCodeeither through a manifest meta-data element or programmatically on theConfigurationobject. This facilitates grouping for custom versioning schemes. By default, theversionCodestill uses theandroid:versionCodemanifest value once aClienthas been instantiated.Changeset
Added integer
versionCodefield toConfigurationwhich can also be read via the AndroidManifestmeta-dataelementcom.bugsnag.android.VERSION_CODE. By default if this value is not configured, theClientwill set theversionCodeto the value supplied inandroid:versionCodeof the AndroidManifest.Tests
Ran the example app and confirmed that for a handled, unhandled, and NDK error, the versionCode reported in the dashboard differs for:
android:versionCodevalue set in the manifestcom.bugsnag.android.VERSION_CODEvalue set in the manifestconfig.versionCodeUpdated existing integration tests to verify that the value is loaded from the manifest and can be overridden.