flushOnLaunch() does not cancel previous requests if they timeout, leading to potential duplicate reports #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancelQueuedFiles() prevents a file being sent again in a duplicate error report. This was inappropriately called in flushOnLaunch() before flushErrorReports() completed in a background thread, which could result in duplicate error reports. This removes the call, immediately cancels non-launch crash reports, and allows flushErrorReport() to cancel/delete each file as appropriate once the request has finished.
kattrali
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
cancelQueuedFiles()prevents a file being sent again in a duplicate error report. This wasinappropriately called in
flushOnLaunch()beforeflushErrorReports()completed in a background thread, which could result in duplicate error reports ifflushAsync()was called while waiting for completion.This changeset removes the call and immediately cancels non-launch crash reports. The SDK not relies on
flushErrorReport(), which cancels/deletes each file once the request has completed.