Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dependencies to androidx #554

Merged
merged 4 commits into from
Aug 13, 2019
Merged

Migrate dependencies to androidx #554

merged 4 commits into from
Aug 13, 2019

Conversation

fractalwrench
Copy link
Contributor

Goal

The support library namespace has changed to androidx.*. We should migrate our compile-time annotation dependency and test dependencies accordingly as this has now been the default in Android for some time, and is beginning to hinder investigations (e.g. installing Fresco in an example app assumes androidx is used).

This should have zero impact on end-users and there is no requirement for them to have upgraded to androidx (as discussed in #504)

Changeset

  • Updated annotations dependency
  • Updated test dependencies to androidx
  • Replaced deprecated InstrumentationRegistry in unit tests with ApplicationProvider
  • Removed RunWith annotation as Junit 4 is the default and the previous annotation is deprecated

Tests

Ran existing tests

@fractalwrench fractalwrench merged commit a307833 into next Aug 13, 2019
@fractalwrench fractalwrench deleted the androidx-migration branch August 13, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants