Convert metadata to map when notifying the NDK observer #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
approved these changes
Jul 2, 2019
kattrali
force-pushed
the
fix-metadata-ndk-crash
branch
from
57ae14a to
a0b72f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Calling
Bugsnag.setMetaData(MetaData())crashed the process if the NDK was enabled. This is because the method emits an observable event to the NDK, which was expected as aMapin the JNI but sent as aMetaData.Changeset
Altered the observable to emit a
Mapinstead.Tests
Tested the change manually in an example app, and added a mazerunner scenario.