Migrate metaData.device.cpuAbi to device.cpuAbi in JSON payload #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rather than metaData.device.cpu
fractalwrench
changed the title
bengourley
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The
cpuAbifield has been added to structured data within the payload, so should ideally be present atdevice.cpuAbi.Changeset
The cpuAbi array is now added into the
deviceobject for both the Java + C report serialisers.Tests
Existing unit tests for JVM serialisation have been updated, and additional steps have been added to mazerunner scenarios to validate the location of this field.
I also manually inspected the payload for handled/unhandled JVM + C crashes, and verified that the field only existed at
device.cpuAbi.