Improve kotlin support by allowing property access

[fractalwrench]

Goal

If public getters/setters are available for a Java field, then this code can be called from Kotlin using the property access syntax. This gives users the choice of using a more Kotlin-esque syntax:

config.autoCaptureSessions = false

while retaining backward compatibility with the previous interface:

config.setAutoCaptureSessions(false)

Changeset

• A public getter and setter were added for the autoCaptureSessions, codeBundleId, and notifierType properties.
• shouldAutoCaptureSessions() was deprecated and forward onto getAutoCaptureSessions()
• Internal use of shouldAutoCaptureSessions() was changed to getAutoCaptureSessions() to avoid using deprecated code
• All KotlinPropertyAccess checks were removed from the lint_baseline file, which suppresses warnings.
• The lint_baseline file was regenerated to account for new violations added in Add binary architecture of application to payload #389, and changes in line numbers.

Tests

Ran existing unit tests + mazerunner scenarios on CI.

[bengourley]

Overall this seems fine.

I do have the following concern though, which I would imagine you probably weighed up…

shouldAutoCaptureSessions() communicates very clearly that calling it will give you the answer to the question "given the current configuration, should sessions be captured automatically?".

getAutoCaptureSessions() sounds more vague, like it could provide you with some class or structure which you would use to capture sessions automatically. However, because this is Java, the fact it returns a boolean helps alleviate some of that mystery but I just think this method name is less good.

Did you consider using an is* prefix, as suggested in the Java-Kotlin interop guide for boolean returning methods? I think it would have to be something like isAutoCapturingSessions in order to make sense in english though…

Aside from the slight naming, the implementation LGTM!

[fractalwrench]

To summarise internal discussion, there are 4 options:

getAutoCaptureSessions, isAutoCaptureSessions, renaming the Java method to isAutoCapturingSessions and losing the property access syntax, or doing nothing.

Of these, getAutoCaptureSessions is the preferred option.