Add Null check when accessing system service #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
context.getSystemService
can return a nullable value. #365 addressed a specific instance where this could cause aNullPointerException
- this PR addresses the other scenarios where this could potentially occur within the SDK, and defaults to a sensible behaviour.Changeset
Added null checks within:
ConnectivityManager
service is nullConnectivityManager
is null, rather than triggering then catching an NPETests
Ran unit tests and mazerunner locally
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: