Fix: serialise breadcrumb message correctly #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the breadcrumb message should be serialised as part of the metadata, not as the name attribute
|
Partially addresses #291 |
Cawllec
reviewed
May 1, 2018
| assertEquals("Hello World", breadcrumb.getMetadata().get("message")); | ||
| } | ||
| } | ||
| assertEquals(1, count); |
There was a problem hiding this comment.
Is the count necessary for this test? And if so, is the for loop the best way to test for it? Would testing the length of the queue be more clear?
There was a problem hiding this comment.
The size and order of the breadcrumb queue cannot be guaranteed when calling client#leaveBreadcrumb, as automatic breadcrumbs may occur at any time (around 6-7 tend to be recorded in practice).
Cawllec
approved these changes
May 1, 2018
kattrali
approved these changes
May 2, 2018
lemnik
pushed a commit
that referenced
this pull request
Jun 2, 2021
Add uploadNdkUnityLibraryMappings flag to bugsnag extension
rich-bugsnag
added a commit
that referenced
this pull request
Sep 3, 2021
fix(ANR): allow other error classes to be reported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breadcrumb message should be serialised as part of the metadata, not as the name attribute.