Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a callback for filtering breadcrumbs #237

Merged
merged 9 commits into from
Feb 9, 2018

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Feb 2, 2018

This adds a callback which allows a developer to specify whether a breadcrumb should be captured or discarded. This also exposes the Breadcrumb class as part of our public API, and allows manipulation of the MetaData. Some duplication within the Breadcrumbs class has also been removed.

Addresses #221

@coveralls
Copy link

coveralls commented Feb 2, 2018

Pull Request Test Coverage Report for Build 1081

  • 57 of 59 (96.61%) changed or added relevant lines in 5 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.3%) to 70.595%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdk/src/main/java/com/bugsnag/android/Bugsnag.java 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
sdk/src/main/java/com/bugsnag/android/Breadcrumbs.java 2 93.33%
sdk/src/main/java/com/bugsnag/android/DeviceData.java 2 76.56%
sdk/src/main/java/com/bugsnag/android/Client.java 3 52.58%
Totals Coverage Status
Change from base Build 1079: 0.3%
Covered Lines: 1755
Relevant Lines: 2486

💛 - Coveralls

* @param breadcrumb the breadcrumb to be captured by Bugsnag
* @see Breadcrumb
*/
boolean send(@NonNull Breadcrumb breadcrumb);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is send the best name for it? If I understand correctly, this method decides if it will "save" not "send" the breadcrumb. I'd call it something like shouldSave(breadcrumb).

@fractalwrench
Copy link
Contributor Author

Updated names in response to feedback from Duncan

@fractalwrench fractalwrench merged commit 1509ae7 into master Feb 9, 2018
@fractalwrench fractalwrench deleted the before-breadcrumb-filter branch February 9, 2018 08:30
lemnik pushed a commit that referenced this pull request Jun 2, 2021
Alter bugsnag extension to allow multiple shared object paths
rich-bugsnag pushed a commit that referenced this pull request Sep 3, 2021
Attach Maze Output as build artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants