Avoid thread-starvation in BackgroundTaskService #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-8892/fix-possible-thread-starvation
branch
from
62be2d5
to
67e8de7
Compare
Android notifier sizes
Generated by 🚫 Danger |
lemnik
requested review from
tomlongridge
and removed request for
kstenerud and
tomlongridge
lemnik
force-pushed
the
PLAT-8892/fix-possible-thread-starvation
branch
from
67e8de7
to
3d8f8b0
Compare
…queue submitting the work to avoid possible thread starvation
lemnik
force-pushed
the
PLAT-8892/fix-possible-thread-starvation
branch
from
3d8f8b0
to
e898f68
Compare
kstenerud
approved these changes
Oct 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid possible thread starvation when submitting tasks to the
BackgroundTaskService.Design
Changed the
BackgroundTaskServiceto internally be able to identify its threads. When the result of aFutureis queried it will first check to see if the task is incomplete&&is queued to be executed on the current thread. If so the task is run immediately and the result is returned.Testing
A new unit test was added that causes thread starvation by adding a task to each queue, which then adds a task to the same queue and then blocks on both tasks to await their completion. This triggers a deadlock as the first task waits for itself to complete.