Preserve ordering of feature flags #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
force-pushed
the
PLAT-8682-feature-flag-order
branch
9 times, most recently
from
3b989fc
to
133a724
Compare
lemnik
approved these changes
Jul 7, 2022
kstenerud
force-pushed
the
PLAT-8682-feature-flag-order
branch
from
133a724
to
788338f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
PLAT-8682: Preserve the order of feature flags in the order they were added or modified.
Design
The NDK implementation has been changed to use a linear search, and to do simple compaction when modifying or clearing a flag.
The JVM implementation simply changes to a LinkedHashMap, and synchronizes the public APIs.
Testing
Updated the unit tests to verify the new behavior.