Fix 'device.locationStatus' on Android 12+ #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-8430/fix-location-status
branch
2 times, most recently
from
868ad37
to
9968193
Compare
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
approved these changes
May 10, 2022
tomlongridge
approved these changes
May 10, 2022
lemnik
force-pushed
the
PLAT-8430/fix-location-status
branch
from
9968193
to
04eb1fc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Report an accurate
device.locationStatusvalue on devices running Android 12 and onwards.Changeset
Use
LocationManager.isLocationEnabledon Android 12+ instead ofSettings.Secure.LOCATION_PROVIDERS_ALLOWED. WhileisLocationEnabledhas been available since Android 9 we will continue to report usingLOCATION_PROVIDERS_ALLOWEDfor all versions before Android 12 so that the exact meaning remains the same.Testing
Manually tested