Rework the background task service shutdown procedure to give more headroom against the 5s ANR timeout #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
PLAT-7995-bgtask-shutdown-await
branch
2 times, most recently
from
c1601f5
to
1caaa32
Compare
Android notifier sizes
Generated by 🚫 Danger |
lemnik
reviewed
Mar 15, 2022
bugsnag-android-core/src/main/java/com/bugsnag/android/BackgroundTaskService.kt
Outdated
Show resolved
Hide resolved
kstenerud
force-pushed
the
PLAT-7995-bgtask-shutdown-await
branch
2 times, most recently
from
e17d3da
to
8958779
Compare
…adroom against the 5s ANR timeout
kstenerud
force-pushed
the
PLAT-7995-bgtask-shutdown-await
branch
from
8958779
to
cdbc9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In a worst case scenario,
BackgroundTaskService.shutdown()could wait for 4.5 seconds to complete a shutdown, which is dangerously close to the 5s limit for an ANR if this happens on the main thread.Rework so that all the shutdowns happen at the same time.
Testing
Rerun all tests. Unfortunately this manifest as a flake in CI so there's no definitive test for it.