Avoid unnecessary network connectivity change breadcrumb #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-7614/avoid-duplicate-connectivity-breadcrumb
branch
from
529f320
to
afc7fb1
Compare
Android notifier sizes
Generated by 🚫 Danger |
fractalwrench
force-pushed
the
PLAT-7614/avoid-duplicate-connectivity-breadcrumb
branch
from
afc7fb1
to
749842e
Compare
fractalwrench
deleted the
PLAT-7614/avoid-duplicate-connectivity-breadcrumb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Android's
ConnectivityManageralways invokes a callback with the current network state whenregisterDefaultNetworkCallbackis called. This led to a network connectivity change breadcrumb being logged on Bugsnag initialization for API >= 24, which wasn't strictly a network change as such.This alters the changeset to ignore the initial change on API 24 and to only log a breadcrumb for subsequent network changes.
Testing
Added unit test coverage and manually confirmed that a breadcrumb is no longer left on Bugsnag initialization as a matter of course, but that genuine network changes afterwards are recorded.