Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compileSdkVersion to apiLevel 31 #1536

Merged
merged 1 commit into from
Nov 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
# Changelog

## TBD

### Enhancements

* Bump compileSdkVersion to apiLevel 31
[#1536](https://github.com/bugsnag/bugsnag-android/pull/1536)

## 5.16.0 (2021-11-29)

## Bug fixes
### Bug fixes

* Increase resilience of NDK stackframe method capture
[#1484](https://github.com/bugsnag/bugsnag-android/pull/1484)
Expand Down
2 changes: 1 addition & 1 deletion bugsnag-benchmarks/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
}

android {
compileSdkVersion 30
compileSdkVersion 31
buildToolsVersion "30.0.3"

compileOptions {
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/kotlin/com/bugsnag/android/Versions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import org.gradle.api.JavaVersion
object Versions {
// Note minSdkVersion must be >=21 for 64 bit architectures
val minSdkVersion = 14
val compileSdkVersion = 30
val compileSdkVersion = 31
val ndk = "17.2.4988734"
val java = JavaVersion.VERSION_1_7
val kotlin = "1.3.72"
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.android-common
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ RUN rm $CMDLINE_TOOLS_NAME

# Install Android tools using sdkmanager
RUN yes | sdkmanager "platform-tools" > /dev/null
RUN yes | sdkmanager "platforms;android-30" > /dev/null
RUN yes | sdkmanager "platforms;android-31" > /dev/null
RUN yes | sdkmanager "ndk;17.2.4988734" > /dev/null
RUN yes | sdkmanager "cmake;3.6.4111459" > /dev/null
RUN yes | sdkmanager "cmake;3.10.2.4988404" > /dev/null
Expand Down
4 changes: 2 additions & 2 deletions examples/sdk-app-example/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ apply plugin: "com.android.application"
apply plugin: "kotlin-android"

android {
compileSdkVersion 30
compileSdkVersion 31
ndkVersion "17.2.4988734"

defaultConfig {
applicationId "com.example.bugsnag.android"
minSdkVersion 14
targetSdkVersion 30
targetSdkVersion 31
versionCode 1
versionName "1.0"
}
Expand Down
3 changes: 2 additions & 1 deletion examples/sdk-app-example/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@

<activity
android:name=".ExampleActivity"
android:label="@string/app_name">
android:label="@string/app_name"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

Expand Down
6 changes: 3 additions & 3 deletions features/fixtures/mazerunner/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ apply plugin: "io.gitlab.arturbosch.detekt"
apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
compileSdkVersion 30
compileSdkVersion 31

defaultConfig {
minSdkVersion 14
targetSdkVersion 30
targetSdkVersion 31
versionCode 34
versionName "1.1.14"
manifestPlaceholders = [
Expand Down Expand Up @@ -55,7 +55,7 @@ android {
pickFirst "**/*.so"
}
lintOptions {
tasks.lint.enabled = false
abortOnError false
}

if (project.hasProperty("TEST_FIXTURE_NDK_VERSION")) {
Expand Down
10 changes: 8 additions & 2 deletions features/fixtures/mazerunner/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,20 @@
android:gwpAsanMode="always"
android:name=".MazerunnerApp"
>
<activity android:name=".MainActivity">
<activity
android:name=".MainActivity"
android:exported="true"
>
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />

</intent-filter>
</activity>
<activity android:name=".SecondActivity">
<activity
android:name=".SecondActivity"
android:exported="true"
>
<intent-filter>
<action android:name="com.bugsnag.android.mazerunner.UPDATE_CONTEXT" />
<category android:name="android.intent.category.DEFAULT" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.app.Activity
import android.content.Context
import android.content.Intent
import android.content.SharedPreferences
import android.os.Build
import android.os.Bundle
import android.widget.Button
import android.widget.EditText
Expand All @@ -24,8 +25,10 @@ class MainActivity : Activity() {
prefs = getPreferences(Context.MODE_PRIVATE)

// Attempt to dismiss any system dialogs (such as "MazeRunner crashed")
val closeDialog = Intent(Intent.ACTION_CLOSE_SYSTEM_DIALOGS)
sendBroadcast(closeDialog)
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.S) {
val closeDialog = Intent(Intent.ACTION_CLOSE_SYSTEM_DIALOGS)
sendBroadcast(closeDialog)
}

// load the scenario first, which initialises bugsnag without running any crashy code
findViewById<Button>(R.id.start_bugsnag).setOnClickListener {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ apply plugin: "io.gitlab.arturbosch.detekt"
apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
compileSdkVersion 30
compileSdkVersion 31

defaultConfig {
minSdkVersion 14
Expand Down
2 changes: 1 addition & 1 deletion features/fixtures/mazerunner/cxx-scenarios/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ apply plugin: "io.gitlab.arturbosch.detekt"
apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
compileSdkVersion 30
compileSdkVersion 31

defaultConfig {
minSdkVersion 14
Expand Down
2 changes: 1 addition & 1 deletion features/fixtures/mazerunner/jvm-scenarios/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ apply plugin: "io.gitlab.arturbosch.detekt"
apply plugin: "org.jlleitschuh.gradle.ktlint"

android {
compileSdkVersion 30
compileSdkVersion 31

defaultConfig {
minSdkVersion 14
Expand Down
4 changes: 2 additions & 2 deletions features/fixtures/minimalapp/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ repositories {
}

android {
compileSdkVersion 30
compileSdkVersion 31

defaultConfig {
applicationId "com.bugsnag.android.minimalapp"
minSdkVersion 14
targetSdkVersion 30
targetSdkVersion 31
versionCode 1
versionName "1.0"
}
Expand Down