Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugins for metadata sections populated using a Map #1454

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Oct 25, 2021

Goal

Ensure that metadata added using addMetadata(String, Map) is correctly sent to all of the plugins.

Testing

Additional unit test for the expected behaviour.

@lemnik lemnik force-pushed the PLAT-7491/add-metadata-by-map branch from 3fe4be1 to e201bd8 Compare October 25, 2021 10:09
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@lemnik lemnik merged commit 320680b into next Oct 25, 2021
@lemnik lemnik deleted the PLAT-7491/add-metadata-by-map branch October 25, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants