Detect systemless root #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge #140 to fix the build issue. |
|
Thanks, @d4rken! I merged manually to pull out the unrelated changes, but this looks good. 👍 |
|
@kattrali Are the other changes against the prefered code style or what's the issue with them? I made those on purpose (wasn't an auto formatter accident). |
|
@d4rken Ah, gotcha. I assumed it was from a formatter. From a maintenance perspective, its hard to look back through commits when a single change can have different purposes. I spend a fair amount of time looking back through rationale for decisions in git history, so generally try to not mix formatting changes in with hot fixes. Outside of that,the changes were a bit different from the existing style, so I the purpose of the change wasn't obvious during review. |
lemnik
pushed a commit
that referenced
this pull request
Jun 2, 2021
Remove support for Jack compiler
rich-bugsnag
pushed a commit
that referenced
this pull request
Sep 3, 2021
feat: disable ANR detection in Unity notifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/su/binshould only exist on rooted device.