Capture ndk thread states #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(threads): add `bsg_thread` to the NDK plugin * feat(thread state): migrate v5 ndk reports to the new v6
* feat(thread state): capture and report native thread states in NDK crashes * fix(native threads): native threads obey `Configuration.sendThreads` * test(native threads): test scenarios for native thread reporting * fix(native threads): map native thread-status codes to a descriptive string
fractalwrench
approved these changes
Sep 28, 2021
lemnik
added a commit
that referenced
this pull request
Sep 29, 2021
* docs: correct changelog entry * test: remove flaky test case * Capture and report `Thread.state` for Android Runtime threads (#1372) * feat(threads): capture and report `Thread.state` for Android Runtime threads * fix(thread state): added nullability annotation to `Thread.State.getDescriptor` * feat(unity): allow Client to be initialised with the Notifier details for reporting (#1386) * Capture ndk thread states (#1390) * feat(threads): add `bsg_thread` to the NDK plugin (#1371) * migrate ndk reports for the new threads property (#1376) * feat(threads): add `bsg_thread` to the NDK plugin * feat(thread state): migrate v5 ndk reports to the new v6 * Capture native thread states (#1384) * feat(thread state): capture and report native thread states in NDK crashes * fix(native threads): native threads obey `Configuration.sendThreads` * test(native threads): test scenarios for native thread reporting * fix(native threads): map native thread-status codes to a descriptive string * fix: updated CHANGELOG for native thread state reporting * v5.14.0 * v5.14.0 - Changelog update Co-authored-by: fractalwrench <fractalwrench@gmail.com>
Merged
lemnik
added a commit
that referenced
this pull request
Sep 30, 2021
* docs: correct changelog entry * test: remove flaky test case * Capture and report `Thread.state` for Android Runtime threads (#1372) * feat(threads): capture and report `Thread.state` for Android Runtime threads * fix(thread state): added nullability annotation to `Thread.State.getDescriptor` * feat(unity): allow Client to be initialised with the Notifier details for reporting (#1386) * Capture ndk thread states (#1390) * feat(threads): add `bsg_thread` to the NDK plugin (#1371) * migrate ndk reports for the new threads property (#1376) * feat(threads): add `bsg_thread` to the NDK plugin * feat(thread state): migrate v5 ndk reports to the new v6 * Capture native thread states (#1384) * feat(thread state): capture and report native thread states in NDK crashes * fix(native threads): native threads obey `Configuration.sendThreads` * test(native threads): test scenarios for native thread reporting * fix(native threads): map native thread-status codes to a descriptive string * fix: updated CHANGELOG for native thread state reporting * v5.14.0 * v5.14.0 - Changelog update Co-authored-by: fractalwrench <fractalwrench@gmail.com> Co-authored-by: fractalwrench <fractalwrench@gmail.com>
This was referenced Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Include a list of application threads and their statuses in crashes produced by the NDK plugin. The data reported includes:
for each thread running at the time the report is generated. This reporting can be enabled or disabled using the existing
sendThreadsoption inConfiguration.Design
Scan the
/proc/self/taskdirectory to retrieve the list of running tasks / threads using signal-safe functions. The status of these threads is read (where possible) into a pre-allocated buffer ofbsg_threads from/proc/self/task/{tid}/statand mapped to human-readable values where required.Testing
New unit tests and Mazerunner scenarios to test that the data is reported when expected, and not reported when the configuration forbids it. Manual end-to-end testing has also been done to ensure the data is ingested and rendered as expected.