Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky test case #1381

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Remove flaky test case #1381

merged 1 commit into from
Sep 23, 2021

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes a flaky test case that ensures a manually cancelled request leaves a network breadcrumb. This is effectively covered by the socketTimeout test case anyway because the call is cancelled by the OkHttpClient after a certain duration.

Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Pending CI

@fractalwrench fractalwrench merged commit ff8809d into next Sep 23, 2021
@fractalwrench fractalwrench deleted the fix-test-flake branch September 23, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants