Use SystemClock.elapsedRealtime to track app.durationInForeground
#1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
app.durationInForeground
fractalwrench
force-pushed
the
PLAT-7121/system-clock-time
branch
from
1269c0d
to
1d66ac9
Compare
Android notifier sizes
Generated by 🚫 Danger |
lemnik
reviewed
Sep 17, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionTracker.java
Show resolved
Hide resolved
fractalwrench
force-pushed
the
PLAT-7121/system-clock-time
branch
from
1d66ac9
to
ee68467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Uses
SystemClock.elapsedRealtime()rather thanSystem.currentTimeMillis()to track thedurationanddurationInForegroundvalues. SystemClock is recommended for timing intervals as it is not affected by CPU power saving mode or the user altering the device time.System.currentTimeMillis()is still used in the codebase elsewhere where accuracy is not as key - for example, adding a timestamp to the filename of persisted errors.Testing
Updated existing test coverage and manually tested to confirm that the values are correct.