Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project to build using Gradle/AGP 7 #1354

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Update project to build using Gradle/AGP 7 #1354

merged 1 commit into from
Sep 3, 2021

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Sep 1, 2021 •
edited
Loading

Goal

Updates the repository to use Gradle 7, building on top of #1353.

Changeset

  • Updated Gradle wrapper to 7.2
  • Bumped license plugin to 0.16.1 which supports Gradle 7
  • Addressed most AGP 7 deprecations
  • Bumped AGP to 7
  • Set abiFilters on android.defaultConfig.ndk as suggested by the NDK setup docs
  • Increased NDK revision from r16 to r17 to circumvent a packaging bug in AGP 7. The revision history does not indicate that this will cause any breaking changes.

Testing

Relied on existing CI coverage.

@fractalwrench fractalwrench changed the title build: update repo to use Gradle 7 Update repo to use Gradle 7 Sep 1, 2021
@fractalwrench fractalwrench force-pushed the PLAT-7098/gradle-7-bump branch 2 times, most recently from 4d84abd to 42be669 Compare September 3, 2021 14:38
@fractalwrench fractalwrench changed the title Update repo to use Gradle 7 Update project to build using Gradle/AGP 7 Sep 3, 2021
@fractalwrench fractalwrench force-pushed the PLAT-7098/gradle-7-bump branch 2 times, most recently from 4a6b87c to 4c4e02f Compare September 3, 2021 14:45
@fractalwrench fractalwrench marked this pull request as ready for review September 3, 2021 15:34
lemnik
lemnik approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit e511d32 into PLAT-7098/build-script-tweaks Sep 3, 2021
@fractalwrench fractalwrench deleted the PLAT-7098/gradle-7-bump branch September 3, 2021 15:47
This was referenced Sep 22, 2021
Merged
Merged
@imjoehaines imjoehaines mentioned this pull request Sep 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @lemnik