app.memoryTrimLevel metadata attribute #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-7108/memory-trim-level-attribute
branch
4 times, most recently
from
1ef1a4f
to
9fe3e38
Compare
kattrali
reviewed
Aug 17, 2021
| bsg_request_env_write_lock(); | ||
| bugsnag_event_add_metadata_bool(&bsg_global_env->next_event, "app", | ||
| "lowMemory", (bool)new_value); | ||
| "low_memory", (bool)low_memory); |
There was a problem hiding this comment.
Was this casing change intentional?
Suggested change
| "low_memory", (bool)low_memory); | |
| "lowMemory", (bool)low_memory); |
There was a problem hiding this comment.
no, absolutely not! thanks for spotting that
…include it in reports
lemnik
force-pushed
the
PLAT-7108/memory-trim-level-attribute
branch
from
9fe3e38
to
0806942
Compare
kattrali
approved these changes
Aug 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add the
app.memoryTrimLevelmetadata attribute for Android error reports. This reports a human-readable description of the most recent value delivered to onTrimMemory.Design
Introduced
MemoryTrimStateto encapsulate thelowMemoryandmemoryTrimLevelvalues and firing theStateEvent.UpdateMemoryTrimEvents to registeredObservers. This also helps to synchronise the state when new Observers (such as the NDK Plugin) are registered, ensuring that events originating from the NDK always have the appropriate fields.Testing
Tested manually, and adjustments to existing tests.