Trim stacktraces to <200 frames before attempting to construct POJOs #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
changed the title
fractalwrench
force-pushed
the
PLAT-6746/trim-stacktrace-early
branch
from
81d8ab6
to
eb094e9
Compare
lemnik
reviewed
Jun 21, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/Stacktrace.kt
Outdated
Show resolved
Hide resolved
…ace.kt Co-authored-by: Jason <lemnik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The notifier trims stacktraces so that they contain a maximum of 200 frames. This means that very large stacktraces such as
StackOverflowErrordo not exceed the API's payload limit.This change ensures that the traces are trimmed before constructing POJOs, which reduces unnecessary object instantiation in this scenario.
Changeset
stacktraceFromJavaTracecompanion object function into a constructorStacktracetrim traces to a maximum of 200 framesTesting
Added unit test for new constructor.