fix: relay onLowMemory events to client Observers #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eports from the NDK layer
lemnik
force-pushed
the
PLAT-6593/fix-lowMemory-on-ndk
branch
from
b59149a
to
3039b82
Compare
fractalwrench
approved these changes
May 24, 2021
lemnik
commented
May 24, 2021
| @@ -42,4 +42,6 @@ sealed class StateEvent { | |||
| class UpdateOrientation(val orientation: String?) : StateEvent() | |||
|
|
|||
| class UpdateUser(val user: User) : StateEvent() | |||
|
|
|||
| class UpdateMemoryTrimEvent(val isLowMemory: Boolean) : StateEvent() | |||
There was a problem hiding this comment.
Note: StateEvent is a public API and is a sealed class
kattrali
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Relay onLowMemory events to the NDK layer through the client Observable so that it will be included in all NDK reports.
Testing
Included a heavily mocked unit test to ensure that the events are relayed to the client Observables. This task also requires manual testing.