fix: avoid recursive Throwable cause chains #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-6557/fix-recursive-cause-chains
branch
from
440c506
to
44de572
Compare
fractalwrench
approved these changes
May 17, 2021
| } else { | ||
| return getRootCause(cause); | ||
| } | ||
| List<Throwable> causes = ThrowableExtensionsKt.safeUnrollCauses(throwable); |
There was a problem hiding this comment.
I think your suggestion of using @file:JvmName("ThrowableUtils") to rename the file would work well here.
fractalwrench
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid errors caused by Throwable.cause chains that are recursive (self-referencing).
Design
Added a method to unroll the cause-chain into a flat List and handle any recursion.
Testing
Added RecursiveThrowableCauseTest to test code that previously had recursion problems, and UnrollThrowableCausesTest to test the contract of the new unroll method.