Update SessionTracker to use BackgroundTaskService #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
session-tracker-bg-changes
branch
from
aeb9a70
to
712c87a
Compare
kstenerud
approved these changes
Mar 11, 2021
Base automatically changed from
background-task-service
to
integration/road-1175-identify-crashes-on-launch
March 11, 2021 14:42
fractalwrench
merged commit b697813
into
integration/road-1175-identify-crashes-on-launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Updates
SessionTrackerto useBackgroundTaskServicerather thanAsync. This allows for better control over asynchronous operations and negates the need for aSemaphorewhich was a source of non-deterministic behaviour that could lead to some session requests not immediately being sent. This is based on changes made in #1182.Changeset
BackgroundTaskServicein theClientSessionTrackerto require aBackgroundTaskServiceconstructor paramSessionTrackerto submit two types of task to the session request executor: flushing stored sessions from disk, and flushing in-memory sessionsTesting
Added a unit test to confirm that requests on the session tracker are confined to a thread, otherwise relied on existing E2E test coverage for sessions.