Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter HTTP requests to stop using chunked transfer encoding #1077

Merged
merged 40 commits into from
Jan 20, 2021
Merged
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
d0b3b50
Alter HTTP requests to stop using chunked transfer encoding
fractalwrench Jan 13, 2021
a96ba7d
Remove all soft fails
twometresteve Jan 15, 2021
40e6250
Remove Android 8.0 - 8.1 is sufficient if passing
twometresteve Jan 15, 2021
8bf35e5
Reinstate skipped Android 8.1 temporarily
twometresteve Jan 15, 2021
ddf8712
Allow for full scheduled builds
twometresteve Jan 15, 2021
6fc7114
Flush out genuine flakes
twometresteve Jan 15, 2021
2ce135c
Use resilient driver
twometresteve Jan 16, 2021
acc3832
Reinstate @Flaky tags for appropriate scenarios
twometresteve Jan 16, 2021
4095227
Remove Flaky marker where no longer believe to be the case
twometresteve Jan 17, 2021
f4d6501
Redundant feature removed
twometresteve Jan 18, 2021
966d8ce
Removed comment
twometresteve Jan 18, 2021
5caac07
Run Flaky tests separately
twometresteve Jan 19, 2021
ed4bc9a
Expect breadcrumb that really should always be there.
twometresteve Jan 19, 2021
cb993d0
Merge branch 'next' into PLAT-5698/chunked-transfer-encoding
fractalwrench Jan 20, 2021
b57f3f4
Merge pull request #1081 from bugsnag/tms/review-flake-tags
fractalwrench Jan 20, 2021
3dfd556
Use in-development Maze Runner
twometresteve Jan 15, 2021
0a089db
Migrate to Maze.driver
twometresteve Jan 15, 2021
928ca87
Migrate to Maze.config
twometresteve Jan 15, 2021
9f2c3ad
Send to separate endpoints
twometresteve Jan 15, 2021
b70df7b
Use Maze namespace
twometresteve Jan 15, 2021
0b13515
Update “the payload field” to error across the board
twometresteve Jan 15, 2021
d70ccfd
Rename “I wait to receive a request” everywhere
twometresteve Jan 15, 2021
7d94773
Use MR docker image
twometresteve Jan 15, 2021
4cc8b9f
Fix test scenarios
twometresteve Jan 15, 2021
80bf42e
Rename steps for consistency
twometresteve Jan 15, 2021
7165cb4
Correct choice of step
twometresteve Jan 15, 2021
35db7b6
Absorb step into MazeRunner
twometresteve Jan 15, 2021
75384c7
Fix smoke tests
twometresteve Jan 15, 2021
532d386
Move steps into maze runner
twometresteve Jan 15, 2021
e3bf168
Use latest MR development branch
twometresteve Jan 16, 2021
bbe1700
Qualify Maze calls
twometresteve Jan 16, 2021
fe51ac8
Updates for Maze v4
twometresteve Jan 16, 2021
d136711
Use session specific step
twometresteve Jan 17, 2021
e3a3538
Correct request type expected
twometresteve Jan 17, 2021
1e65fbe
Merge pull request #1080 from bugsnag/tms/maze-v4
fractalwrench Jan 20, 2021
a956495
ci: add missing tags from mazerunner buildkite yaml
fractalwrench Jan 20, 2021
62c34d9
Various updates for flaking scenarios
twometresteve Jan 20, 2021
4b28a20
test: reinstate flaky test flag for failing test
fractalwrench Jan 20, 2021
d50d83a
Merge pull request #1082 from bugsnag/tms/further-flake-updates
fractalwrench Jan 20, 2021
29a67fc
ci: fix yaml
fractalwrench Jan 20, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 22 additions & 63 deletions .buildkite/pipeline.full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand Down Expand Up @@ -101,6 +102,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -122,11 +124,9 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'
# temp workaround browserstack network issue where 400 status codes fail the tests
soft_fail:
- exit_status: "*"

- label: ':android: Android 5 NDK r16 end-to-end tests - batch 1'
depends_on:
Expand All @@ -146,10 +146,9 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':android: Android 5 NDK r16 end-to-end tests - batch 2'
depends_on:
Expand All @@ -169,10 +168,9 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':android: Android 6 NDK r16 end-to-end tests - batch 1'
depends_on:
Expand All @@ -192,6 +190,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -213,11 +212,9 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'
# temp workaround browserstack network issue where 400 status codes fail the tests
soft_fail:
- exit_status: "*"

- label: ':android: Android 7 NDK r19 end-to-end tests - batch 1'
depends_on:
Expand All @@ -237,6 +234,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -258,34 +256,9 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'
# temp workaround browserstack network issue where 400 status codes fail the tests
soft_fail:
- exit_status: "*"

- label: ':android: Android 8.0 NDK r19 end-to-end tests'
depends_on:
- "fixture-r19"
- "android-8-smoke"
timeout_in_minutes: 60
plugins:
artifacts#v1.2.0:
download: "build/release/fixture-r19.apk"
docker-compose#v3.7.0:
run: android-maze-runner
command:
- "features/full_tests"
- "--app=/app/build/release/fixture-r19.apk"
- "--farm=bs"
- "--device=ANDROID_8_0"
- "--fail-fast"
- "--tags"
- "not @Flaky"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':android: Android 8.1 NDK r19 end-to-end tests - batch 1'
depends_on:
Expand All @@ -305,6 +278,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -326,6 +300,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -347,6 +322,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -368,6 +344,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -389,6 +366,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -410,6 +388,7 @@ steps:
- "--fail-fast"
- "--tags"
- "not @Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -434,6 +413,7 @@ steps:
- "--farm=bs"
- "--device=ANDROID_4_4"
- "--tags=@Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -455,10 +435,9 @@ steps:
- "--farm=bs"
- "--device=ANDROID_5_0"
- "--tags=@Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':hankey: Flaky Android 6 NDK r16 end-to-end tests'
depends_on:
Expand All @@ -478,6 +457,7 @@ steps:
- "--farm=bs"
- "--device=ANDROID_6_0"
- "--tags=@Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -499,32 +479,10 @@ steps:
- "--farm=bs"
- "--device=ANDROID_7_1"
- "--tags=@Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':hankey: Flaky Android 8.0 NDK r19 end-to-end tests'
depends_on:
- "fixture-r19"
timeout_in_minutes: 60
plugins:
artifacts#v1.2.0:
download: "build/release/fixture-r19.apk"
docker-compose#v3.7.0:
run: android-maze-runner
command:
- "features/full_tests"
- "--retry=2"
- "--strict-undefined"
- "--strict-pending"
- "--app=/app/build/release/fixture-r19.apk"
- "--farm=bs"
- "--device=ANDROID_8_0"
- "--tags=@Flaky"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':hankey: Flaky Android 8.1 NDK r19 end-to-end tests'
depends_on:
- "fixture-r19"
Expand All @@ -543,10 +501,9 @@ steps:
- "--farm=bs"
- "--device=ANDROID_8_1"
- "--tags=@Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':hankey: Flaky Android 10 NDK r21 end-to-end tests'
depends_on:
Expand All @@ -566,6 +523,7 @@ steps:
- "--farm=bs"
- "--device=ANDROID_10_0"
- "--tags=@Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -587,5 +545,6 @@ steps:
- "--farm=bs"
- "--device=ANDROID_11_0"
- "--tags=@Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'
50 changes: 26 additions & 24 deletions .buildkite/pipeline.quick.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ steps:
- "--fail-fast"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':android: Android 6 NDK r16 smoke tests'
key: 'android-6-smoke'
Expand Down Expand Up @@ -55,26 +53,6 @@ steps:
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':android: Android 8.0 NDK r19 smoke tests'
key: 'android-8-smoke'
depends_on: "fixture-r19"
timeout_in_minutes: 60
plugins:
artifacts#v1.2.0:
download: "build/release/fixture-r19.apk"
docker-compose#v3.7.0:
run: android-maze-runner
command:
- "features/smoke_tests"
- "--app=/app/build/release/fixture-r19.apk"
- "--farm=bs"
- "--device=ANDROID_8_0"
- "--fail-fast"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':android: Android 8.1 NDK r19 smoke tests'
key: 'android-8-1-smoke'
depends_on: "fixture-r19"
Expand All @@ -92,8 +70,6 @@ steps:
- "--fail-fast"
concurrency: 9
concurrency_group: 'browserstack-app'
soft_fail:
- exit_status: "*"

- label: ':android: Android 9 NDK r21 smoke tests'
key: 'android-9-smoke'
Expand Down Expand Up @@ -131,6 +107,8 @@ steps:
- "--retry=1"
- "--strict-undefined"
- "--strict-pending"
- "--tags"
- "not @Flaky"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand All @@ -152,6 +130,30 @@ steps:
- "--retry=1"
- "--strict-undefined"
- "--strict-pending"
- "--tags"
- "not @Flaky"
concurrency: 9
concurrency_group: 'browserstack-app'

- label: ':hankey: Flaky Android 9 NDK r21 end-to-end tests'
depends_on:
- "fixture-r21"
timeout_in_minutes: 60
plugins:
artifacts#v1.2.0:
download: "build/release/fixture-r21.apk"
docker-compose#v3.7.0:
run: android-maze-runner
command:
- "features/full_tests"
- "--retry=2"
- "--strict-undefined"
- "--strict-pending"
- "--app=/app/build/release/fixture-r21.apk"
- "--farm=bs"
- "--device=ANDROID_9_0"
- "--tags=@Flaky"
- "--resilient"
concurrency: 9
concurrency_group: 'browserstack-app'

Expand Down
3 changes: 2 additions & 1 deletion .buildkite/pipeline_trigger.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ if [[ "$BUILDKITE_MESSAGE" == *"[barebones ci]"* ]]; then
barebones_description
elif [[ "$BUILDKITE_MESSAGE" == *"[full ci]"* ||
"$BUILDKITE_BRANCH" == "next" ||
"$BUILDKITE_BRANCH" == "master" ]]; then
"$BUILDKITE_BRANCH" == "master" ||
! -z "$FULL_SCHEDULED_BUILD" ]]; then
echo "Running full build"
echo "Unit and static tests will be run"
echo "All instrumentation tests will be run"
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## TBD

* Alter HTTP requests to stop using chunked transfer encoding
[#1077](https://github.com/bugsnag/bugsnag-android/pull/1077)

## 5.5.0 (2021-01-07)

This release supports initializing Bugsnag in multi processes apps. If your app uses Bugsnag in multiple processes, you should initialize Bugsnag
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
source "https://rubygems.org"

# You can run against local Maze Runner branches and uncommitted changes:
#gem 'bugsnag-maze-runner', path: '../maze-runner'
gem 'bugsnag-maze-runner', path: '../maze-runner'

# Or a specific release:
gem 'bugsnag-maze-runner', git: 'https://github.com/bugsnag/maze-runner', tag: 'v3.7.2'
#gem 'bugsnag-maze-runner', git: 'https://github.com/bugsnag/maze-runner', tag: 'v3.7.2'

# Or follow master:
#gem 'bugsnag-maze-runner', git: 'https://github.com/bugsnag/maze-runner'
10 changes: 5 additions & 5 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
GIT
remote: https://github.com/bugsnag/maze-runner
revision: d022bf3269fe1a36c7f719f91d0e9f243ce70577
tag: v3.7.2
PATH
remote: ../maze-runner
specs:
bugsnag-maze-runner (3.7.2)
bugsnag-maze-runner (4.0.0)
appium_lib (~> 10.2)
boring (~> 0.1.0)
cucumber (~> 3.1.2)
cucumber-expressions (~> 6.0.0)
curb (~> 0.9.6)
Expand All @@ -27,6 +26,7 @@ GEM
faye-websocket (~> 0.11.0)
selenium-webdriver (~> 3.14, >= 3.14.1)
backports (3.20.1)
boring (0.1.0)
builder (3.2.4)
childprocess (3.0.0)
cucumber (3.1.2)
Expand Down
Loading