Merge pull request #97 from bugsnag/limit-stored-errors

Limit number of stored errors

src/main/java/com/bugsnag/android/ErrorStore.java

@@ -3,6 +3,8 @@
 import java.io.File;
 import java.io.FileWriter;
 import java.io.Writer;
+import java.util.Arrays;
+import java.util.List;
 
 import android.content.Context;
 
@@ -12,6 +14,7 @@
  */
 class ErrorStore {
     private static final String UNSENT_ERROR_PATH = "/bugsnag-errors/";
+    private static final int MAX_STORED_ERRORS = 100;
 
     final Configuration config;
     final String path;
@@ -77,6 +80,20 @@ public void run() {
     void write(Error error) {
         if(path == null) return;
 
+        // Limit number of saved errors to prevent disk space issues
+        File exceptionDir = new File(path);
+        if (exceptionDir.isDirectory()) {
+            File[] files = exceptionDir.listFiles();
+            if (files.length >= MAX_STORED_ERRORS) {
+                // Sort files then delete the first one (oldest timestamp)
+                Arrays.sort(files);
+                Logger.warn(String.format("Discarding oldest error as stored error limit reached (%s)", files[0].getPath()));
+                if (!files[0].delete()) {
+                    files[0].deleteOnExit();
+                }
+            }
+        }
+
         String filename = String.format("%s%d.json", path, System.currentTimeMillis());
         Writer out = null;
         try {