review feedback

bugsnag · Jul 15, 2019 · 211372d · 211372d
1 parent 0720ad3
commit 211372d
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 7 deletions.
diff --git a/bugsnag-android-core/src/androidTest/java/com/bugsnag/android/AppDataTest.java b/bugsnag-android-core/src/androidTest/java/com/bugsnag/android/AppDataTest.java
@@ -52,7 +52,7 @@ public void setUp() throws Exception {
 
     @Test
     public void testAccessors() {
-        assertEquals("com.bugsnag.android.jvm.test", appData.get("packageName"));
+        assertEquals("com.bugsnag.android.core.test", appData.get("packageName"));
         assertNull(appData.get("buildUUID"));
         assertTrue(((Long) appData.get("duration")) > 0);
         assertEquals(500L, appData.get("durationInForeground"));
@@ -68,7 +68,7 @@ public void testJsonSerialisation() throws JSONException {
         assertEquals("1.0", appDataJson.get("version"));
         assertEquals("development", appDataJson.get("releaseStage"));
         assertEquals("android", appDataJson.get("type"));
-        assertEquals("com.bugsnag.android.jvm.test", appDataJson.get("id"));
+        assertEquals("com.bugsnag.android.core.test", appDataJson.get("id"));
         assertNotNull(appDataJson.get("buildUUID"));
         assertTrue(((Long) appData.get("duration")) > 0);
         assertEquals(500L, appData.get("durationInForeground"));

diff --git a/bugsnag-android-core/src/androidTest/java/com/bugsnag/android/ClientTest.java b/bugsnag-android-core/src/androidTest/java/com/bugsnag/android/ClientTest.java
@@ -330,7 +330,7 @@ public void testAppDataMetaData() {
         Map<String, Object> app = client.getAppData().getAppDataMetaData();
         assertEquals(6, app.size());
         assertEquals("Bugsnag Android Tests", app.get("name"));
-        assertEquals("com.bugsnag.android.jvm.test", app.get("packageName"));
+        assertEquals("com.bugsnag.android.core.test", app.get("packageName"));
         assertEquals("1.0", app.get("versionName"));
         assertNotNull(app.get("memoryUsage"));
         assertTrue(app.containsKey("activeScreen"));

diff --git a/bugsnag-android-core/src/androidTest/java/com/bugsnag/android/ProjectPackagesTest.kt b/bugsnag-android-core/src/androidTest/java/com/bugsnag/android/ProjectPackagesTest.kt
@@ -13,7 +13,7 @@ class ProjectPackagesTest {
         assertNull(configuration.projectPackages)
 
         val client = Client(InstrumentationRegistry.getContext(), configuration)
-        assertArrayEquals(arrayOf("com.bugsnag.android.jvm.test"), client.config.projectPackages)
+        assertArrayEquals(arrayOf("com.bugsnag.android.core.test"), client.config.projectPackages)
         client.close()
     }
 

diff --git a/bugsnag-android-core/src/main/AndroidManifest.xml b/bugsnag-android-core/src/main/AndroidManifest.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-  package="com.bugsnag.android.jvm">
+  package="com.bugsnag.android.core">
 
   <!-- Required: Used to deliver Bugsnag crash reports -->
   <uses-permission android:name="android.permission.INTERNET" />

diff --git a/bugsnag-android-core/src/main/java/com/bugsnag/android/NativeInterface.java b/bugsnag-android-core/src/main/java/com/bugsnag/android/NativeInterface.java
@@ -10,7 +10,6 @@
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
-import java.util.Observer;
 import java.util.Queue;
 
 /**

diff --git a/gradle.properties b/gradle.properties
@@ -11,7 +11,7 @@ org.gradle.jvmargs=-Xmx1536m
 # This option should only be used with decoupled projects. More details, visit
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 # org.gradle.parallel=true
-VERSION_NAME=4.16.1
+VERSION_NAME=4.16.0
 GROUP=com.bugsnag
 POM_SCM_URL=https://github.com/bugsnag/bugsnag-android
 POM_SCM_CONNECTION=scm:git@github.com:bugsnag/bugsnag-android.git