Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v3.2.8 #115

Merged
merged 5 commits into from
Jun 21, 2018
Merged

Release v3.2.8 #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7cdcd4e
test: update ndk mazerunner scenario to remove armeabi support (no lo…
fractalwrench Jun 8, 2018
dfb3ed0
Merge pull request #113 from bugsnag/fix-ci
fractalwrench Jun 11, 2018
12a30bf
fix: fix automatic config of proguard for ndk library
fractalwrench Jun 21, 2018
c8f9396
docs: add changelog entry for proguard keep rule ndk fix
fractalwrench Jun 21, 2018
2bc6e6f
Merge pull request #114 from bugsnag/fix-proguard-autoconfig
fractalwrench Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 3.2.8 (2018-06-21)

### Bug fixes

* Update ProGuard keep rules for Breadcrumb class, fixing NDK compatibility
[Jamie Lynch](https://github.com/fractalwrench) [#114](https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/114)

## 3.2.7 (2018-06-05)

### Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion features/fixtures/ndkapp/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ android {
}
arm {
ndk {
abiFilters "armeabi-v7a", "armeabi"
abiFilters "armeabi-v7a"
}
}
}
Expand Down
7 changes: 2 additions & 5 deletions features/ndk_app.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Feature: Plugin integrated in NDK app

Scenario: NDK apps send requests
When I build the NDK app
Then I should receive 7 requests
Then I should receive 6 requests

And the request 0 is valid for the Build API
And the payload field "appVersion" equals "1.0" for request 0
Expand All @@ -27,8 +27,5 @@ Scenario: NDK apps send requests
And the request 4 is valid for the Android NDK Mapping API
And the payload field "apiKey" equals "your-api-key-here" for request 4

And the request 5 is valid for the Android NDK Mapping API
And the request 5 is valid for the Android Mapping API
And the payload field "apiKey" equals "your-api-key-here" for request 5

And the request 6 is valid for the Android Mapping API
And the payload field "apiKey" equals "your-api-key-here" for request 6
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
group = com.bugsnag
version = 3.2.7
version = 3.2.8

ANDROID_MIN_SDK_VERSION=14
ANDROID_TARGET_SDK_VERSION=27
Expand Down
1 change: 1 addition & 0 deletions src/main/groovy/com/bugsnag/android/gradle/BugsnagProguardConfigTask.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class BugsnagProguardConfigTask extends DefaultTask {
static final String PROGUARD_CONFIG_SETTINGS = """\
-keepattributes LineNumberTable,SourceFile
-keep class com.bugsnag.android.NativeInterface { *; }
-keep class com.bugsnag.android.Breadcrumb { *; }
-keep class com.bugsnag.android.Breadcrumbs { *; }
-keep class com.bugsnag.android.Breadcrumbs\$Breadcrumb { *; }
-keep class com.bugsnag.android.BreadcrumbType { *; }
Expand Down