Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by updating NDK mazerunner scenario #113

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Fix CI by updating NDK mazerunner scenario #113

merged 1 commit into from
Jun 11, 2018

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Jun 8, 2018

Armeabi no longer seems to be a supported architecture on the Travis CI image. This changeset alters the product flavors to only target armeabi-v7a and updates the scenario, so that the CI build no longer breaks.

Changeset

Changed

Removed armeabi variant, updated scenario expectations

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@fractalwrench fractalwrench requested a review from a team June 8, 2018 13:39
@fractalwrench fractalwrench merged commit dfb3ed0 into next Jun 11, 2018
@fractalwrench fractalwrench deleted the fix-ci branch June 11, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants