Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache version variable #78

Merged
merged 3 commits into from
May 18, 2024
Merged

fix: cache version variable #78

merged 3 commits into from
May 18, 2024

Conversation

lotyp
Copy link
Member

@lotyp lotyp commented May 10, 2024

What was changed

Made trap version to be as static property of Info class,

Why?

If multiple requests to Info class are made in one request cycle, there should be no additional requests to FS

src/Info.php Outdated Show resolved Hide resolved
src/Info.php Outdated Show resolved Hide resolved
src/Info.php Outdated Show resolved Hide resolved
src/Info.php Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Please upload report for BASE (master@54c1e51). Learn more about missing BASE report.

Files Patch % Lines
src/Info.php 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #78   +/-   ##
=========================================
  Coverage          ?   24.24%           
  Complexity        ?     1122           
=========================================
  Files             ?      129           
  Lines             ?     3399           
  Branches          ?        0           
=========================================
  Hits              ?      824           
  Misses            ?     2575           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit a73c7c0 into master May 18, 2024
23 of 25 checks passed
@roxblnfk roxblnfk deleted the feat/auto-version branch May 18, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants