Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix psalm, clear psalm-baseline.yaml: Test, Http, Sentry, Sender.php #64

Merged
merged 4 commits into from
May 6, 2024
Merged

Fix psalm, clear psalm-baseline.yaml: Test, Http, Sentry, Sender.php #64

merged 4 commits into from
May 6, 2024

Conversation

dimajolkin
Copy link
Contributor

Second mini part of clear psalm-baseline.yml

@butschster butschster requested a review from roxblnfk May 5, 2024 18:31
@butschster butschster added the enhancement New feature or request label May 5, 2024
@roxblnfk roxblnfk force-pushed the fix-psalm-clear-baseline-part2 branch from 4fb9db0 to 82b695b Compare May 6, 2024 09:05
@roxblnfk
Copy link
Member

roxblnfk commented May 6, 2024

Thanks.
As you can see, we are trying not to use psalm-suppress if we can avoid it. Also, it's necessary to create new branches from the latest master branch commit to have zero conflicts.

@roxblnfk roxblnfk merged commit 3cde966 into buggregator:master May 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimajolkin @roxblnfk @butschster