Fix dupicated requests on linux #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue was introduced while fixing windows c9274ac Added exception for Windows, which by default allows interfaces without IPs. Interface name check moved higher, so if interface namee or IP match, rest of check will be ignored. Additionally windows npcap loopback mechanism can now be picked by specifying 127.0.0.1 or loopback IP. Fix #989
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
xingren23
referenced
this pull request
in xingren23/goreplay
Sep 4, 2021
Issue was introduced while fixing windows buger@c9274ac Added exception for Windows, which by default allows interfaces without IPs. Interface name check moved higher, so if interface namee or IP match, rest of check will be ignored. Additionally windows npcap loopback mechanism can now be picked by specifying 127.0.0.1 or loopback IP. Fix #989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was introduced while fixing windows c9274ac
Added exception for Windows, which by default allows interfaces without IPs.
Interface name check moved higher, so if interface namee or IP match, rest of check will be ignored.
Additionally windows npcap loopback mechanism can now be picked by specifying 127.0.0.1 or loopback IP.
Fix #989