address comment

Signed-off-by: bufferflies <1045931706@qq.com>
bufferflies · Aug 11, 2023 · d4f9c16 · d4f9c16
1 parent 035ec42
commit d4f9c16
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/server/cluster/cluster.go b/server/cluster/cluster.go
@@ -311,7 +311,7 @@ func syncConfig(ctx context.Context, manager *config.StoreConfigManager, stores
 	for index := 0; index < len(stores); index++ {
 		select {
 		case <-ctx.Done():
-			log.Info("stop sync store config job due to server shutdown")
+			log.Info("stop sync store config job due to raft cluster exited")
 			return false
 		default:
 		}

diff --git a/server/config/store_config.go b/server/config/store_config.go
@@ -15,7 +15,6 @@
 package config
 
 import (
-	"bytes"
 	"context"
 	"encoding/json"
 	"fmt"
@@ -231,7 +230,7 @@ func newTiKVConfigSource(schema string, client *http.Client) *TiKVConfigSource {
 func (s TiKVConfigSource) GetConfig(ctx context.Context, statusAddress string) (*StoreConfig, error) {
 	url := fmt.Sprintf("%s://%s/config", s.schema, statusAddress)
 	ctx, cancel := context.WithTimeout(ctx, clientTimeout)
-	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, bytes.NewBuffer(nil))
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
 	if err != nil {
 		cancel()
 		return nil, fmt.Errorf("failed to create store config http request: %w", err)