Fix running tests in Windows #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perezd
reviewed
Jun 18, 2024
buf/internal/toolchain.bzl
Outdated
| @@ -52,13 +52,13 @@ _buf_toolchain = rule( | |||
|
|
|||
| def declare_buf_toolchains(os, cpu, rules_buf_repo_name): | |||
| for cmd in ["buf", "protoc-gen-buf-lint", "protoc-gen-buf-breaking"]: | |||
| ext = "" | |||
| exe_suffix = "" | |||
There was a problem hiding this comment.
ultra nit: cmd_suffix would be clearer.
srikrsna
approved these changes
Jun 19, 2024
srikrsna-buf
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the toolchain registration issue from #78.
Also, it adds a batch script version of the shell script shim used to invoke protoc for tests; however, this requires
--enable_runfilesto be explicitly passed or added to.bazelrcfor a project, as Bazel on Windows does not populate runfiles by default.In the future, we will need a better approach to supporting Windows that uses the runfiles manifest instead. This is tricky though, and will require some careful thought.